Automatic refresh #1026
Merged
Automatic refresh #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
requested review from
jakub-rdx,
giannis-rdx and
sergiupuhalschi-rdx
…layed the first batch of data
micbakos-rdx
force-pushed
the
account-refresh
branch
from
ea5a86c
to
6b2a183
Compare
giannis-rdx
approved these changes
Jul 5, 2024
Comment on lines
+101
to
+103
| observeAccountAssets() | ||
| observeGlobalAppEvents() | ||
| observeSecurityPrompt() |
| @@ -110,7 +105,7 @@ class WalletViewModel @Inject constructor( | |||
| } | |||
| } | |||
| observePrompts() | |||
| observeAccounts() | |||
| observeWallet() | |||
There was a problem hiding this comment.
my only objection is here. "wallet" is quite generic. It seems like observing everything in the wallet?
If not observeAccounts then maybe observeWalletAssets?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WalletViewModelregarding the structure of state and how it is represented. More detailed types for refresh and price state exist and give more flexibility to preserve state and convey it to the user.How to test